[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

[Zachary Turner via lldb-commits]

We already have this exact code in lldb/cmake/LLDBConfig.txt.  This fix
looks fine, but I see no reason to have it twice, so can you delete the
LLDB version?

On Mon, Apr 17, 2017 at 7:01 AM Kamil Rytarowski via Phabricator <
reviews at reviews.llvm.org> wrote:

> krytarowski added a comment.
>
> Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms
> 20+ years ago.
>
> It's perhaps no-op, but it might be noted in the commit message what
> platforms are supposed to be improved.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32125
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170417/aca63d20/attachment.html>