[Lldb-commits] [PATCH] D31822: [NFC] Adding a new wrapper for getaddrinfo

[Chris Bieneman via Phabricator via lldb-commits]

beanz added inline comments.


================
Comment at: include/lldb/Host/SocketAddress.h:44-45
+  //----------------------------------------------------------------------------
+  static std::vector<SocketAddress> GetAddressInfo(const char *hostname,
+                                                 const char *servname);
+
----------------
zturner wrote:
> What about using `Twine` here instead of `const char *` literals?
I don't want to use `Twine` for this because in other patches I'm pulling this into debugserver which doesn't have any dependency on LLVM.


https://reviews.llvm.org/D31822