[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

[Chris Bieneman via Phabricator via lldb-commits]

beanz added a comment.

@labath, I could adapt this into the `MainLoop` class, but I would actually want to change how that class hierarchy is implemented. Regardless of the event handling/polling model you use much of the code is identical between the classes. I'd rather get rid of `MainLoopPosix` and `MainLoopBase` and instead just implement a portable `MainLoop` class.

In particular the difference between Windows `WSAPoll` and posix `poll(2)` is the name of two functions, which makes the idea of having separate Windows and Posix implementations just seem overly complicated to me, although neither Darwin nor Windows have `ppoll` because it isn't POSIX, and Windows doesn't have `pselect`, so there isn't a remotely portable way to wait on file descriptors and signals... This is why we can't have nice things.

I'm going to dig into the `MainLoop` code. At first glance I do think that is a better way to fit this all together, but I'm going to need to think on it and experiment a bit.


https://reviews.llvm.org/D31823