[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added a comment.

Hmm still wrong.

Later in this code:

  // NetBSD per-thread information is stored in notes named
  // "NetBSD-CORE at nnn" so match on the initial part of the string.
  m_os = llvm::Triple::NetBSD;
  if (note.n_type == NETBSD::NT_PROCINFO) {
    ParseNetBSDProcInfo(*thread_data, note_data);
  } else if (note.n_type == NETBSD::NT_AUXV) {
    m_auxv = DataExtractor(note_data);
  } else if (arch.GetMachine() == llvm::Triple::x86_64 &&
             note.n_type == NETBSD::NT_AMD64_REGS) {
    thread_data->gpregset = note_data;
  } else if (arch.GetMachine() == llvm::Triple::x86_64 &&
             note.n_type == NETBSD::NT_AMD64_FPREGS) {
    thread_data->fpregset = note_data;
  }

`arch.GetMachine()` evaluates to `llvm::Triple::UnknownArch` and `gpregset` and `fpregset` is never set.

Changing `ArchSpec arch = GetArchitecture();` to `ArchSpec arch = GetTarget().GetArchitecture();` does not help... I'm trying to investigate.


Repository:
  rL LLVM

https://reviews.llvm.org/D31825