[Lldb-commits] [PATCH] D31451: New C++ function name parsing logic

[Eugene Zemtsov via lldb-commits]

Thanks for vigilance. I added a couple more tests in r299729.

On Thu, Apr 6, 2017 at 4:06 PM, Jim Ingham via Phabricator <
reviews at reviews.llvm.org> wrote:

> jingham added a comment.
>
> I'm sorry, I don't have time actually review the code here for
> correctness...  But can you make sure that this also rejects a two or three
> field selector, not just "selector:" but "selector:otherField:"?  That
> seems sufficiently different that you might get the one : but not the two :
> form right.  You could test 3 & more colons, but at that point it's
> probably overkill.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D31451
>
>
>
>


-- 
Thanks,
Eugene Zemtsov.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170406/f5d638b9/attachment.html>