[Lldb-commits] [Diffusion] rL299714: iwyu fixes for lldbCore.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 6 15:41:27 PDT 2017

Agreed.  Before I clang-formatted it, it looked fine, because each
definition was on a single line.  But clang-format made them 3 lines each.
So yea, we should definitely merge them.  I was copy/pasting the output
from IWYU, which is why it looks this way.  Thanks for bringing it up

On Thu, Apr 6, 2017 at 3:32 PM Tamas Berghammer via Phabricator <
reviews at reviews.llvm.org> wrote:

> tberghammer added subscribers: lldb-commits, tberghammer.
> tberghammer added inline comments.
> /lldb/trunk/include/lldb/Core/Address.h:21-50 I think we should try to
> merge these namespace definitions as in my view the current syntax makes
> the top of the file very noisy. What do you think?
> Users:
>   zturner (Author)
> https://reviews.llvm.org/rL299714
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170406/b37f70d6/attachment.html>

More information about the lldb-commits mailing list