[Lldb-commits] [PATCH] D31485: Verify memory address range validity in GDBRemoteCommunicationClient

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 31 03:00:25 PDT 2017

labath accepted this revision.
labath added a comment.

Thank you for adding the test. Lgtm, assuming the second getmemoryregioninfo call is accidental.

Comment at: unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:373
+  result = std::async(std::launch::async, [&] {
+    return client.GetMemoryRegionInfo(addr, region_info);
This seems out of place. Should we delete it?


More information about the lldb-commits mailing list