[Lldb-commits] [PATCH] D31450: Battery of NetBSD support improvements

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 29 06:39:31 PDT 2017

labath added inline comments.

Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249
+      // Initialize new thread
+      struct ptrace_lwpinfo info = {};
+      Error error = PtraceWrapper(PT_LWPINFO, pid, &info, sizeof(info));
This is the third place i'm seeing this code. Any chance of turning it into a function?

Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:447
+    for (const auto &thread_sp : m_threads) {
+      static_pointer_cast<NativeThreadNetBSD>(thread_sp)->SetStepping();
+    }
I guess you should be playing with the pt_suspend/resume here to step only the requested thread(s). Is that something you plan to do as a follow up?



More information about the lldb-commits mailing list