[Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 28 11:56:13 PDT 2017

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

If SetName is the wrong thing to use for synthetic child providers, then we need to make Clone available to the SB API's as well.  In any case where they want to return an extant ValueObject with a different name - as opposed to making one up out of whole cloth - won't they need the same operation?

Also, probably should document this requirement in the varformats.html.

Comment at: include/lldb/Core/ValueObject.h:607-610
+  // Creates a copy of the ValueObject with a new name setting he current value
+  // object as its parent. It should be used when we want to chane the name of a
+  // value object without modifying the actul value object (e.g. sythetic child
+  // provider).
Spelling... "he" -> "the", "chane" -> "change",  "actul" -> "actual" 


More information about the lldb-commits mailing list