[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 28 09:00:05 PDT 2017


labath added inline comments.


================
Comment at: source/CMakeLists.txt:25
+include_directories(
+  Plugins/Process/POSIX
+  )
----------------
krytarowski wrote:
> @labath are the includes for Plugins/Process/FreeBSD and Plugins/Process/FreeBSD necessary? I don't need to add Plugins/Process/NetBSD in order to make things work.
> 
> (it's not related to OpenBSD patch here)
You probably need the ProcessPosixLog file at least. However, the only thing which this affects is how you need to include them, so if you use the long `Plugins/Process/POSIX/XXX` path, you are fine.

As a matter of fact, we should probably use that path everywhere, and then these can go away. (future cleanup idea).


https://reviews.llvm.org/D31131





More information about the lldb-commits mailing list