[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Mar 19 20:00:55 PDT 2017


krytarowski added inline comments.


================
Comment at: include/lldb/Host/Config.h:35
+
+#include "lldb/Host/openbsd/Config.h"
 
----------------
krytarowski wrote:
> Missing in patch?
I think that Config.h should go away. It's almost empty. But it's beyond the scope of this patch.

While there I would sort this list of includes again.


================
Comment at: include/lldb/Host/HostInfo.h:55
+#elif defined(__OpenBSD__)
+#include "lldb/Host/openbsd/HostInfoOpenBSD.h"
+#define HOST_INFO_TYPE HostInfoOpenBSD
----------------
I would sort includes here.


Repository:
  rL LLVM

https://reviews.llvm.org/D31131





More information about the lldb-commits mailing list