[Lldb-commits] [PATCH] D31129: Remove remaining platform specific code from FileSpec

[Zachary Turner via Phabricator via lldb-commits]

zturner updated this revision to Diff 92287.
zturner added a comment.

Turns out `ResolveUsername` was only being called from one place outside of `FileSpec` and `ResolvePartialUsername` was dead code (since callers had already been updated to use `TildeExpressionResolver`.  So I just deleted these two functions and replaced the calls to `ResolveUsername` with calls directly into `TildeExpressionResolver`.


https://reviews.llvm.org/D31129

Files:
  lldb/include/lldb/Host/FileSpec.h
  lldb/include/lldb/Utility/TildeExpressionResolver.h
  lldb/source/API/SBDeclaration.cpp
  lldb/source/API/SBFileSpec.cpp
  lldb/source/API/SBFileSpecList.cpp
  lldb/source/API/SBLineEntry.cpp
  lldb/source/Host/common/FileSpec.cpp
  lldb/source/Host/windows/FileSystem.cpp
  lldb/source/Host/windows/HostInfoWindows.cpp
  lldb/source/Target/TargetList.cpp
  lldb/source/Utility/TildeExpressionResolver.cpp
  lldb/unittests/Interpreter/TestCompletion.cpp
  lldb/unittests/Utility/CMakeLists.txt
  lldb/unittests/Utility/TildeExpressionResolverTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31129.92287.patch
Type: text/x-patch
Size: 19495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170319/90eb85e2/attachment-0001.bin>