[Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 16 08:05:54 PDT 2017


It's fine, just checking :)

lgtm

On Thu, Mar 16, 2017 at 7:49 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added a comment.
>
> In https://reviews.llvm.org/D31031#702747, @zturner wrote:
>
> > You mention that this was the cause of dependencies from `Host` to
> `Target`, but I don't see any `#include "lldb/Target/*.h"` statements
> removed.  Is this an oversight or not possible yet?
>
>
> I guess I wasn't clear about that. One of the GetAuxvData overloads was
> taking a `Process*` argument, but this is by no means the last dependency
> on stuff from the Target module.
>
>
> https://reviews.llvm.org/D31031
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170316/a3222621/attachment.html>


More information about the lldb-commits mailing list