[Lldb-commits] [PATCH] D30981: Remove HostThreadLinux/Free/NetBSD

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added inline comments.


================
Comment at: source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:128
+      if (kp == nullptr || (error != 0 && errno == ENOMEM)) {
+        // Add extra space in case threads are added before next call.
+        len += sizeof(*kp) + len / 10;
----------------
Besides my other notes about dedicated ptrace(2) call for reading thread name on FreeBSD, I'm not sure whether FreeBSD supports "online" debugging (there was a dedicated GDB term I forgot right now) of a running process. If so, there is no need extra space approach.


https://reviews.llvm.org/D30981