[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Regain Module Name if memory_info.GetName() is empty

[Pavel Labath via Phabricator via lldb-commits]

labath added a subscriber: tberghammer.
labath added inline comments.


================
Comment at: source/Core/DynamicLoader.cpp:193
         memory_info.GetRange().GetRangeBase() == base_addr) {
+      // Regain name if memory_info.GetName is empty
+      if (memory_info.GetName().IsEmpty())
----------------
This is wrong. The only reason we are querying the `GetMemoryRegionInfo` is to retrieve the file name, so falling back to the original makes whole effort  pointless.

Would it work for you if you modified the `if` above to only retry these checks only if `GetMemoryRegionInfo` actually returned a valid (non-empty) filename ?


https://reviews.llvm.org/D30454