[Lldb-commits] [PATCH] D30927: Normalize the LLVM cmake path before appending it to the module path

[Hugh Bellamy via Phabricator via lldb-commits]

hughbe created this revision.
hughbe added a project: LLDB.
Herald added a subscriber: mgorny.

LLVM_CMAKE_PATH has backlashes in it. CMake then tries to append this to CMAKE_MODULE_PATH but gets confused and errors out as it thinks we're providing an escape sequence (that's unknown, causing generation to fail)

E.g "C:\Users\hugh..."

I've been porting swift to Windows/MSVC. This was causing the Windows build to fail and I submitted a PR (https://github.com/apple/swift-lldb/pull/156). Maybe it belongs upstream, however


Repository:
  rL LLVM

https://reviews.llvm.org/D30927

Files:
  modules/LLDBStandalone.cmake


Index: modules/LLDBStandalone.cmake
===================================================================
--- modules/LLDBStandalone.cmake
+++ modules/LLDBStandalone.cmake
@@ -69,6 +69,7 @@
 
   set(LLVMCONFIG_FILE "${LLVM_CMAKE_PATH}/LLVMConfig.cmake")
   if(EXISTS ${LLVMCONFIG_FILE})
+    get_filename_component(LLVM_CMAKE_PATH ${LLVM_CMAKE_PATH} ABSOLUTE)
     list(APPEND CMAKE_MODULE_PATH "${LLVM_CMAKE_PATH}")
     include(${LLVMCONFIG_FILE})
   else()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30927.91667.patch
Type: text/x-patch
Size: 458 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170314/e3f915cc/attachment.bin>