[Lldb-commits] [PATCH] D30807: Use LLVM's directory enumeration code

[Zachary Turner via lldb-commits]

You're right, I didn't notice that. But since you mention it, surely that
had to have been a bug in the original implementation right? That flag
isn't intended to be a synonym for "non recursive iteration ", because
that's what the Next enumeration value is for. The algorithm would
intentionally leave that decision up to the callback.

Find directories seems to want to mean "should you call my callback with
directories?"

Imagine someone wants all files recursively but nothing else, that was
impossible before, they would have to opt in to seeing each directory just
so they could return Enter
On Fri, Mar 10, 2017 at 2:27 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added a comment.
>
>
>
>
>
> ================
> Comment at: lldb/source/Host/common/FileSpec.cpp:786
> +      continue;
> +    if (!find_directories && fs::is_directory(Status))
> +      continue;
> ----------------
> This looks like it changes behavior. Previously, if `find_directories` was
> false this function would *not* recurse into them, whereas now it will. I
> guess you did not intend to do that (?)
>
>
> https://reviews.llvm.org/D30807
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170310/a4986ff9/attachment.html>