[Lldb-commits] [PATCH] D30817: BreakpointResolverFileLine: Correct treatment of move-to-nearest-code for multiple modules

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.

move-to-nearest-code needs special treatment to avoid creating
superfluous breakpoints in case multiple compilation units. It already
had code to handle the case when the compilation units are in the same
module, but it still did not properly handle the case when the
compilation units are in different modules.

This fixes the issue by manually iterating over the modules (instead of
just CUs) to make sure we aggregate the matches properly.


https://reviews.llvm.org/D30817

Files:
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/Makefile
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/TestMoveNearest.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/foo.cpp
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/foo.h
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/main.cpp
  source/Breakpoint/BreakpointResolverFileLine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30817.91310.patch
Type: text/x-patch
Size: 8058 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170310/4cbabd7a/attachment-0001.bin>