[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Zachary, unfortunately I had to revert this -- while investigating the breakages I've found a problem I don't think any of us realised -- llvm's statting code is based on stat(2), while lldb uses lstat(2). I think we need to go back and re-audit each case to see whether the behavior difference is a problem. In most of the cases, I think using stat would make things simpler (no need to special case symlink as a file type), but at least one case (SymbolFileDWARF) really depends on the lstat behavior (not resolving symlinks), so we need to figure out how to handle that.


Repository:
  rL LLVM

https://reviews.llvm.org/D30624