[Lldb-commits] [lldb] r297013 - Fix Log unit tests

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 6 09:27:34 PST 2017


Weird, I could have sworn I fixed this.  But looking at my disk, it's
sitting uncommitted :-/

On Mon, Mar 6, 2017 at 7:29 AM Pavel Labath via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> Author: labath
> Date: Mon Mar  6 09:17:36 2017
> New Revision: 297013
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297013&view=rev
> Log:
> Fix Log unit tests
>
> the llvm function for getting the thread name dropped the _np suffix
> during review. Zachary's commit did not reflect that.
>
> Modified:
>     lldb/trunk/unittests/Utility/LogTest.cpp
>
> Modified: lldb/trunk/unittests/Utility/LogTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/LogTest.cpp?rev=297013&r1=297012&r2=297013&view=diff
>
> ==============================================================================
> --- lldb/trunk/unittests/Utility/LogTest.cpp (original)
> +++ lldb/trunk/unittests/Utility/LogTest.cpp Mon Mar  6 09:17:36 2017
> @@ -73,9 +73,8 @@ TEST(LogTest, log_options) {
>        "World 47\n",
>        GetLogString(LLDB_LOG_OPTION_PREPEND_FILE_FUNCTION, "Hello World
> {0}", 47));
>
> -  EXPECT_EQ(llvm::formatv("[{0,0+4}/{1,0+4}] Hello World 47\n",
> -                          ::getpid(),
> -                          llvm::get_threadid_np())
> +  EXPECT_EQ(llvm::formatv("[{0,0+4}/{1,0+4}] Hello World 47\n",
> ::getpid(),
> +                          llvm::get_threadid())
>                  .str(),
>              GetLogString(LLDB_LOG_OPTION_PREPEND_PROC_AND_THREAD,
>                           "Hello World {0}", 47));
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170306/28ff1bf0/attachment-0001.html>


More information about the lldb-commits mailing list