[Lldb-commits] [PATCH] D30622: Remove FileSpec::ReadFileContents

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 6 08:13:54 PST 2017

Previous message: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions
Next message: [Lldb-commits] [PATCH] D30622: Remove FileSpec::ReadFileContents
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks great. One thing I'd consider is adding a function which returns the data buffer as a StringRef (`AsStringRef()` ?) instead of the GetChars function, but I don't feel strongly about it.


https://reviews.llvm.org/D30622

Previous message: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions
Next message: [Lldb-commits] [PATCH] D30622: Remove FileSpec::ReadFileContents
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the lldb-commits mailing list