[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

Tamas Berghammer via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 6 03:58:59 PST 2017


tberghammer added a comment.

Can you make the usage of "using namespace llvm::sys::fs;" a bit more consistent? Sometime you write fully qualified name, sometime you add it to the top of the file while sometime only to the function where it is used.



================
Comment at: llvm/include/llvm/Support/FileSystem.h:482-486
 /// @brief Does status represent a directory?
 ///
 /// @param status A file_status previously returned from status.
 /// @returns status.type() == file_type::directory_file.
+file_type get_file_type(const Twine &Path);
----------------
Please fix the comment


https://reviews.llvm.org/D30624





More information about the lldb-commits mailing list