[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Yes, that is a good solution.  It's still a little awkward that DataExtractors live in Utility and their dumper lives in Core.  Especially as almost all the functionality of the dumper could live in Utility.  If you were serious about using Utility separate from Core you would want to put the non-target parts of DumpDataExtractor into Core and assert if those are passed the unsupported flavors, and then have DumpDataExtractorTarget, with the instruction and fancy float bits.  But maybe that's work for another day.

We name functions starting with a Capitol first letter, so these should be "Dump..." not "dump...".  But other than that, this seems good.


https://reviews.llvm.org/D30560