[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The EH stuff should definitely go in a specific subclass.

It also seems a shame to lose the capability to Dump DataExtractors in general.  The only thing the exe_scope is used for in Dump (which is what is causing you problems) is to print instructions, and to do a more accurate job of printing non-native floats.  It would be best to leave the Dump without these bits in the base data extractor, and return an error for the unsupported format kinds, and then add a Dump method that takes an exe_scope in the subclass (now DataExtractorTargetAware???)


https://reviews.llvm.org/D30560