[Lldb-commits] [PATCH] D30560: Split DataExtractor into two classes.

[Zachary Turner via Phabricator via lldb-commits]

zturner created this revision.
Herald added subscribers: aprantl, mgorny.

The goal is to move `DataBuffer`, `DataBufferLLVM`, `DataBufferHeap`, `DataExtractor`, and `DataEncoder` from `Core` to `Utility`.  All of this is a straightforward move except for `DataExtractor`, which has 3 methods which depend on the target and various debug info things.

The most sensible way I can come up with to do the split is to move those 3 functions into a subclass of `DataExtractor`, and update those callsites that use those 3 functions to use the new subclass.

After this change it should be a straightforward move to get the various `DataBuffer` and family classes into `Utility`.


https://reviews.llvm.org/D30560

Files:
  lldb/include/lldb/Core/DataExtractor.h
  lldb/include/lldb/Core/DataExtractorEx.h
  lldb/include/lldb/Symbol/ClangASTContext.h
  lldb/include/lldb/Symbol/CompilerType.h
  lldb/include/lldb/Symbol/DWARFCallFrameInfo.h
  lldb/include/lldb/Symbol/GoASTContext.h
  lldb/include/lldb/Symbol/JavaASTContext.h
  lldb/include/lldb/Symbol/OCamlASTContext.h
  lldb/include/lldb/Symbol/Type.h
  lldb/include/lldb/Symbol/TypeSystem.h
  lldb/source/API/SBData.cpp
  lldb/source/Commands/CommandObjectMemory.cpp
  lldb/source/Core/Address.cpp
  lldb/source/Core/CMakeLists.txt
  lldb/source/Core/DataExtractor.cpp
  lldb/source/Core/DataExtractorEx.cpp
  lldb/source/Core/Event.cpp
  lldb/source/Core/RegisterValue.cpp
  lldb/source/DataFormatters/TypeFormat.cpp
  lldb/source/Expression/Materializer.cpp
  lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
  lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
  lldb/source/Symbol/ClangASTContext.cpp
  lldb/source/Symbol/CompilerType.cpp
  lldb/source/Symbol/GoASTContext.cpp
  lldb/source/Symbol/JavaASTContext.cpp
  lldb/source/Symbol/OCamlASTContext.cpp
  lldb/source/Symbol/Type.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30560.90423.patch
Type: text/x-patch
Size: 110593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170303/2508b239/attachment-0001.bin>