[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

[Eugene Zemtsov via Phabricator via lldb-commits]

eugene added inline comments.


================
Comment at: source/Plugins/Process/Utility/RegisterContextFreeBSD_mips64.cpp:31
+// Number of register sets provided by this context.
+enum { k_num_register_sets = 1 };
+
----------------
Here and below why not use 

constexpr size_t k_num_register_sets = 1;

it seems much more straightforward than enum-for-consts trick. 


================
Comment at: source/Plugins/Process/Utility/RegisterContextFreeBSD_mips64.cpp:104
+     return &g_reg_sets_mips64[set];
+   return NULL;
+}
----------------
nullptr?


================
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:75
+      else if (!abi.compare("o32"))
+        return 96;
+      // N32 ABI
----------------
96, 72, 128... where do these number come from? 
May be they should be put them into constants and document them somehow.


https://reviews.llvm.org/D30457