[Lldb-commits] [PATCH] D30410: testsuite/android: build test executables with the android ndk directly

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.





================
Comment at: packages/Python/lldbsuite/test/make/Android.rules:1
+NDK_ROOT := $(shell dirname $(CC))/../../../../..
+NDK_ROOT := $(realpath $(NDK_ROOT))
----------------
tberghammer wrote:
> Will this file work on Windows (e.g. dirname, realpath, forward slash)?
I copied this from the main makefile, so I am pretty sure it will. Why will it work is a different question though. :)


================
Comment at: packages/Python/lldbsuite/test/make/Android.rules:4-13
+ifeq "$(findstring $(ARCH), aarch64 x86_64)" "$(ARCH)"
+	# lowest 64-bit API level
+	API_LEVEL := 21
+else ifeq "$(ARCH)" "i386"
+	# clone(2) declaration is present only since this api level
+	API_LEVEL := 17
+else
----------------
tberghammer wrote:
> Does it make sense to use a different API level for every architecture? I think making it somewhat consistent would make it easier to use it
Well.. there's no guarantee that an API 21 file will run on an older device. They seem to run fine, but I'd like to avoid relying on that if it is possible. We can always increase the number if it becomes a maintenance burden.


https://reviews.llvm.org/D30410