[Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 24 10:55:55 PST 2017
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks fine.
It reads a little odd to me that the BreakpointSP recipient of GetSP is generally called opaque_sp after the patch. Historically it makes sense because it was the result of the substitution m_opaque_sp -> opaque_sp. But if you didn't know that it might seem odd, since there's nothing opaque about it. Something like "bkpt_sp" would read more naturally. OTOH is does make the patch larger, so I don't feel very strongly about it.
More information about the lldb-commits