[Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 24 07:18:04 PST 2017
I left out unit tests since we'd essentially be duplicating the unit tests
of MemoryBuffer, and because it involves the file system (also this is
temporary code until DataBuffer stuff goes away). Lmk if you disagree
On Fri, Feb 24, 2017 at 2:53 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:
> labath added a comment.
> I am not sure if this is a voting situation, but I agree with what Zachary
> said above.
> Since we're already speaking about tests, it looks like the new
> DataBufferLLVM class could use a unit test or two, just so we get in the
> habit of writing those.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits