[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for Arm/AArch64 targets

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

lgtm, thanks.



================
Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/main.cpp:30
+
+  hw_break_mutex.lock();
+  
----------------
I know it's only a test program, but you generally should never lock the mutex manually.

`std::lock_guard<std::mutex> guard(mutex)`


https://reviews.llvm.org/D29669