[Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: lldb/include/lldb/Core/DataBufferLLVM.h:43
+  uint8_t *GetBytes() override {
+    llvm_unreachable("Not implemented!");
+    return nullptr;
----------------
labath wrote:
> This makes pretty much everything fail. Most of the code base has a reference to a non-const DataBuffer, which then just segfaults after calling this. I think you'll have to return a const_cast of the buffer here for now.
That's too bad, although I guess this problem will go away in the future if I can replace `DataBuffer` with either `llvm::MemoryBuffer` or `llvm::BinaryStream`.


https://reviews.llvm.org/D30054