[Lldb-commits] [PATCH] D30251: Map ELF files as writable so we can update the relocations in them

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 22 07:03:46 PST 2017

Yea if this isn't urgent, can we wait for my other changes to go in?

Llvm does support mapping writable, but not through the same interface. So
it should still work
On Wed, Feb 22, 2017 at 6:43 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added a reviewer: zturner.
> labath added a comment.
> Adding Zachary as he was about to remove this code.
> The timing of this patch is a bit unfortunate, as it would complicate the
> removal of the code in question. If I am not mistaken, llvm's version
> currently does not support copy-on-write mappings, which is what we are
> trying to do here. The c-o-w could certainly be added there, and we will
> probably need to do it in the future, but I am not sure whether this is the
> right time for it. I don't want to impede Zachary's cleanup effort due to a
> "feature" that noone has serious commitment of supporting.
> https://reviews.llvm.org/D30251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170222/cd1f0bbe/attachment.html>

More information about the lldb-commits mailing list