[Lldb-commits] [PATCH] D30234: Reformat inferior's main.cpp in lldb-server test

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 22 01:50:22 PST 2017

labath added a comment.

clang-format did not pick up the correct formatting because we have a `.clang-format` file in `packages/Python/lldbsuite`. This was necessary because a lot of the tests would get broken, as the formatting would break our `// place breakpoint here` annotations (also, stepping behavior is affected by the line breaks). It would be an interesting project to format all existing tests, but this would probably need to be done on a test-by-test basis (and may involve adding additional clang-format directives like CommentPragmas, ...).

That said, none of these problems should apply to lldb-server tests as they operate differently, so reformatting them is probably a good idea. I guess you should also then put a `.clang-format` file in the lldb-server test folder to make sure it stays formatted in the future.


More information about the lldb-commits mailing list