[Lldb-commits] [PATCH] D30172: Replace WINLOG_*** macros with LLDB_LOG

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.

The main difference here is that in the WINLOG macros you can specify
log categories per call, whereas here you have to go the usual lldb
route of getting a Log* variable first. While this means you have to
write at least two statements, it usually means that each statement will
fit on a single line, whereas fitting the WINLOG invocation on a single
line was almost impossible. So the total size of code does not increase
even in functions with a single log statement, and functions with more
logging get shorter.

The downside here is reduced flexibility in specifying the log
categories, which a couple of functions used quite heavily (e.g.
RefreshStateAfterStop). For these I chose a single category used most
prominently and put everything into that, although a solution with
multiple log variables is definitely possible.


https://reviews.llvm.org/D30172

Files:
  source/Plugins/Process/Windows/Common/DebuggerThread.cpp
  source/Plugins/Process/Windows/Common/ProcessWindows.cpp
  source/Plugins/Process/Windows/Common/ProcessWindowsLog.cpp
  source/Plugins/Process/Windows/Common/ProcessWindowsLog.h
  source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
  source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30172.89130.patch
Type: text/x-patch
Size: 55268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170220/37372b34/attachment-0001.bin>