[Lldb-commits] [PATCH] D29888: Fix debug build of unit tests
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Feb 13 03:45:42 PST 2017
labath created this revision.
Herald added a subscriber: mgorny.
It turns out listing each library twice is not enough to resolve all
references in a debug build on linux - a number of executables fails to
link with random symbols missing. Increasing the number to three seems
to be enough. The choice of lldbCore to set the multiplicity on is
somewhat arbitrary, but it seems fitting, as it is the biggest layering
transgressor.
https://reviews.llvm.org/D29888
Files:
source/Core/CMakeLists.txt
Index: source/Core/CMakeLists.txt
===================================================================
--- source/Core/CMakeLists.txt
+++ source/Core/CMakeLists.txt
@@ -85,3 +85,6 @@
Demangle
)
+# Needed to properly resolve references in a debug build.
+# TODO: Remove once we have better layering
+set_target_properties(lldbCore PROPERTIES LINK_INTERFACE_MULTIPLICITY 3)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29888.88177.patch
Type: text/x-patch
Size: 381 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170213/ad7f9b28/attachment.bin>
More information about the lldb-commits
mailing list