[Lldb-commits] [PATCH] D29823: Clean up debug logging

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 10 05:07:27 PST 2017


labath created this revision.

We've had two ways to print a "debug" log message.

- Log::GetDebug() was testing a Stream flag which was never set.
- Log::Debug() was checking for the presence of "log enable --debug"

flag.

Given that these two were used very rarely and we already have a
different way to specify "I want a more verbose log", I propose to remove
these two functions and migrate the callers to LLDB_LOGV. This commit
does that.


https://reviews.llvm.org/D29823

Files:
  include/lldb/Core/Log.h
  source/Commands/CommandObjectLog.cpp
  source/Core/Log.cpp
  source/Core/StringList.cpp
  source/DataFormatters/FormatManager.cpp
  source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29823.87987.patch
Type: text/x-patch
Size: 11624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170210/3b333b4a/attachment-0001.bin>


More information about the lldb-commits mailing list