[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 8 16:57:07 PST 2017

labath added a comment.

Thank you for the review. I'll submit this tomorrow.

In https://reviews.llvm.org/D29615#670879, @clayborg wrote:

> Looks good as long as if we type two log enable commands like:
>   (lldb) log enable -f /tmp/a.txt lldb process
>   (lldb) log enable -f /tmp/a.txt lldb api

Yes, the log file still gets shared. I am not changing that.

> @zturner:
>  Aside from the thread stuff, nothing seems particularly risky about this change.  Did the thread-local stuff you removed have anything to do with the -t option to the log command?

Well... the thread-safe logging would make that unnecessary, but with the current temporary-buffer implementation you don't need that even without threadsafe logging. This makes be believe the logging callback was written before we had the temporary buffer logic in place, but I haven't dug through the history to verify that.


More information about the lldb-commits mailing list