[Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

The log callback gets passed down from the SB API (in the SBDebugger constructor, no less). My best guess is that it is (was?) used to display the debugger log in some IDE window.



================
Comment at: source/Core/StreamCallback.cpp:22
 StreamCallback::StreamCallback(lldb::LogOutputCallback callback, void *baton)
-    : Stream(0, 4, eByteOrderBig), m_callback(callback), m_baton(baton),
-      m_accumulated_data(), m_collection_mutex() {}
----------------
zturner wrote:
> I find it rather odd that this was hardcoding big endian.  Was the endianness here important for some reason?
I think that was there just because you needed to specify some value. As we were always printing strings, it did not matter anyway.


https://reviews.llvm.org/D29615