[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.





================
Comment at: source/Target/SectionLoadList.cpp:70
                                             bool warn_multiple) {
-  Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER |
-                                                  LIBLLDB_LOG_VERBOSE));
-
+  Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER));
   ModuleSP module_sp(section->GetModule());
----------------
zturner wrote:
> There's a subtle behavioral change here, which is that previously this line would get logged even if `LIBLLDB_LOG_DYNAMIC_LOADER` was not set, and now it won't.  However, I've always found the `GetLogIfAny` / `GetLogIfAll` split unnecessarily confusing, so I'm not opposed to this change.  Just want to point it out.
You're right I didn't notice that. However, I suspect that this was actually not intended, so it should be fine. It'd be interesting to see how many calls to IfAny/IfAll we have with more than one category after this change.


================
Comment at: source/Target/SectionLoadList.cpp:76
+              section.get(), module_sp->GetFileSpec(),
+              section->GetName().AsCString(), load_addr, module_sp.get());
 
----------------
zturner wrote:
> No need to call `AsCString()`.
We don't have a formatter for ConstString yet. I'll interpret this as a request to add one.


https://reviews.llvm.org/D29510