[Lldb-commits] [PATCH] D29514: Change Error::PutToLog to LLDB_LOG_ERROR

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

looks good, just make sure it compiles.



================
Comment at: lldb/include/lldb/Core/Log.h:18
 #include "lldb/Utility/ConstString.h"
+#include "lldb/Utility/Error.h"
 #include "lldb/lldb-private.h"
----------------
This is also unnecessary.


================
Comment at: lldb/include/lldb/Utility/Error.h:14
 
+#include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/Twine.h"
----------------
All these includes are now unnecessary :)


================
Comment at: lldb/source/Host/common/Host.cpp:911
           eErrorTypePOSIX);
-      if (log && (error.Fail() || log))
-        error.PutToLog(log,
----------------
lol :)


================
Comment at: lldb/source/Host/common/Host.cpp:952
+      if (error.Fail())
+        LLDB_LOG_ERROR(
+            log, error, "posix_spawn_file_actions_addopen (action={0}, "
----------------
looks like you forgot this one.


https://reviews.llvm.org/D29514