[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 3 14:32:45 PST 2017
zturner added inline comments.
================
Comment at: source/Target/SectionLoadList.cpp:70
bool warn_multiple) {
- Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER |
- LIBLLDB_LOG_VERBOSE));
-
+ Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER));
ModuleSP module_sp(section->GetModule());
----------------
There's a subtle behavioral change here, which is that previously this line would get logged even if `LIBLLDB_LOG_DYNAMIC_LOADER` was not set, and now it won't. However, I've always found the `GetLogIfAny` / `GetLogIfAll` split unnecessarily confusing, so I'm not opposed to this change. Just want to point it out.
================
Comment at: source/Target/SectionLoadList.cpp:76
+ section.get(), module_sp->GetFileSpec(),
+ section->GetName().AsCString(), load_addr, module_sp.get());
----------------
No need to call `AsCString()`.
https://reviews.llvm.org/D29510
More information about the lldb-commits
mailing list