[Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 3 12:59:40 PST 2017


labath created this revision.

Per discussion in https://reviews.llvm.org/D28616, having two ways two request logging (log
enable lldb XXX verbose && log enable -v lldb XXX) is confusing. This
removes the first option and standardizes all code to use the second
one.

I've added a LLDB_LOGV macro as a shorthand for if(log &&
log->GetVerbose()) and switched most of the affected log statements to
use that (I've only left a couple of cases that were doing complex
computations in an if(log) block).


https://reviews.llvm.org/D29510

Files:
  include/lldb/Core/Log.h
  include/lldb/Core/Logging.h
  source/API/SBBroadcaster.cpp
  source/API/SBEvent.cpp
  source/Core/DataBufferMemoryMap.cpp
  source/Core/Logging.cpp
  source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp
  source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.cpp
  source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.cpp
  source/Plugins/Platform/MacOSX/PlatformRemoteiOS.cpp
  source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
  source/Target/Memory.cpp
  source/Target/SectionLoadList.cpp
  source/Target/ThreadPlanCallFunction.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29510.87006.patch
Type: text/x-patch
Size: 33701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170203/5d224808/attachment-0001.bin>


More information about the lldb-commits mailing list