[Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: lldb/source/Target/ThreadList.cpp:387
         if (log)
-          log->Printf("ThreadList::%s thread 0x%4.4" PRIx64
-                      ": voted %s, but lost out because result was %s",
-                      __FUNCTION__, thread_sp->GetID(), GetVoteAsCString(vote),
-                      GetVoteAsCString(result));
+          log->Format(
+              __FILE__, __FUNCTION__,
----------------
labath wrote:
> Any reason for not using the log macro here? (replace `if(log) log->Format)` with `LLDB_LOG(log, ...)`).
> 
> I did not anticipate using this function directly as the `__FILE__` , ` __FUNCTION__` thingies make it very obnoxious.
Ahh, this is the first time I've written a logging statement since your changes, I think I'm just not accustomed to the new way yet.  I can update this though.


https://reviews.llvm.org/D29359