[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

> Interesting. Passing to what? I thought it means we shouldn't pass non-trivial types through variadic arguments (... expression), and in this case we don't do it because  CMIUtilString is the type of the parameter vFormating which has a name.

Presumably the "undefinedness" comes from the fact that `va_start` uses the last non-... argument to locate the variadic args on the stack. And a non-POD type may cause the stack to be layed out in a way the the function does not expect.


Repository:
  rL LLVM

https://reviews.llvm.org/D29256