[Lldb-commits] [PATCH] D29095: Open ELF core dumps with more than 64K sections

Eugene Birukov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 27 17:22:25 PST 2017

EugeneBi added inline comments.

Comment at: source/Plugins/ObjectFile/ELF/ELFHeader.cpp:108
+  if (ok) {
+    if (e_phnum_hdr == 0xFFFF)
+      e_phnum = section_zero.sh_info;
EugeneBi wrote:
> EugeneBi wrote:
> > davidb wrote:
> > > Would this make more sense to compare against a named constant ELF::PN_XNUM?
> > Would be nice, but - where is it defined? I tried ELF::PN_XNUM, elf::PN_XNUM, PN_XNUM - compiler barks anyway.
> > 
> OK, I see the other two are defined in Support/ELF.h, I'll put PN_XNUM there then.
Oh, this ELF.h is a part of a different git repo - it lives in llvm. I am not sure what to do about it.


More information about the lldb-commits mailing list