[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Ok, I've just checked and this does not happen on windows. It does however happen (GetTriple() returning None) when we try to open the s390x core file (functionalities/postmortem/elf-core/linux-s390x.out). The test suite seems to be handling it fine.

The only difference I see there is that the other test has a bit of setUp/tearDown code which saves and restores the original platform after each run. Can you check whether that will make things work for you ? (It's still not ideal, but at least it will be consistent with the other test).

As an alternative fix -- the checking of the *target* platform in the code which is throwing this exception seems to be a bug. "Whether we have an LLDB.framework" is a property of the host, not the target. Changing that would probably allow you to make progress here. (although it won't fix the underlying problem).


Repository:
  rL LLVM

https://reviews.llvm.org/D29215