[Lldb-commits] [PATCH] D29144: LLDB: fix for TestCallThatThrows.py test fail

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

Can you explain in more detail the scenario this is addressing?  You seem to be handling a case where some plan has been completed, but it is not the function call plan we are waiting for.  What was the completed thread plan which WAS done but wasn't the function call thread plan?  Calling nested functions is tricky, and I'd like to understand what is going on when this goes wrong.

BTW, if you only have a Mac available to you, you may be able to reproduce the Linux behavior locally by going into ProcessGDBRemote::DoAllocateMemory and turning off the code that checks SupportsAllocDeallocMemory, forcing us to use the InferiorMmap call instead.  That might make development easier for you.


Repository:
  rL LLVM

https://reviews.llvm.org/D29144