[Lldb-commits] [PATCH] D28945: Add completed_plan_stack to LLDB ThreadStateCheckpoint

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

I can't think of a case where you would need the discarded plans to stick around across a function call, I don't think you need to preserve that stack.

I do worry a bit about how the completed plans go away, mostly as you say because of breakpoints which could be left without their ThreadPlan handlers.  The simplest proceeding is to convert all the Destructor cleanups to WillPop and then just call that in the destructor.  That way the real cleanup goes on when the plan is popped and the destructor is just a safety backup.  Leaving the plans around longer increases the risk of this: especially when we know we are changing behavior to leave completed plans around while running a function call thread plan.

I did that conversion for the Function call thread plans a while back, but must have gotten interrupted on the way to doing them all.  Anyway, I doesn't make sense to gate this change on completing that piece of work.


https://reviews.llvm.org/D28945