[Lldb-commits] [PATCH] D29036: Add format_provider for lldb::StateType

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 23 09:43:26 PST 2017


clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Very close, just add a test for a bad value since someone can have code like:

  StateType state;
  llvm::formatv("{0}", state);

Just to make sure we don't crash during logging. Can remember what lldb_private::StateAsCString(...) returns, but I am guessing it is NULL for a bad state, so we need to make sure the logging won't crash with that.


https://reviews.llvm.org/D29036





More information about the lldb-commits mailing list