[Lldb-commits] [PATCH] D28945: Add completed_plan_stack to LLDB ThreadStateCheckpoint

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

BTW, this shows one important difference between OS X and Linux that pops up from time to time.  On OS X, we can allocate memory in the target process without having to call functions in the target.  We don't do that by hand in lldb (that wouldn't work for remote debugging) rather we have a packet we send to debugserver, and it does the allocation.  But the Linux lldb-server doesn't have this ability so on Linux, lldb ends up having to make and run a ThreadPlanCallFunction from awkward places in processing stops.  This works for the most part, but it sometimes requires tweaks like this.

This functionality gets tested pretty rigorously just by using lldb on Linux, since this gets done as a side effect of many operations.  So it is tested indirectly by the test suite.  I'm not sure how you would test this directly, however.


Repository:
  rL LLVM

https://reviews.llvm.org/D28945